fix(server): preserve Kubernetes sandbox security - #1506
Draft
prazgaitis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
runAsNonRootandrunAsUserthrough the server's Kubernetes security-context helpersWhy
The generic list replacement in the Kubernetes template merge replaced the template sandbox container with the runtime container. That silently discarded template-owned capability drops,
allowPrivilegeEscalation, and resource settings. Separately, a pod-level non-root identity overrode the egress init/sidecar requirements, preventing IPv6/nftables setup.The name-aware merge follows Kubernetes' merge-key convention while leaving unnamed lists such as commands and tolerations replace-only. No API or CRD shape changes.
Validation
uv run pytest tests/k8s/test_batchsandbox_provider.py tests/k8s/test_batchsandbox_template.py tests/k8s/test_egress_helper.py -q— 180 passedlinux/arm64server image build — passedopensandbox-server --helpsmoke — passedRuntimeDefaultseccomp, all capabilities dropped, no privilege escalation, retained resource limits, and working egress